mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
net: make WriteTo fail when UDPConn is already connected
Fixes #2773. R=rsc CC=golang-dev https://golang.org/cl/5571056
This commit is contained in:
parent
93e547a0c2
commit
974fa75557
5 changed files with 113 additions and 17 deletions
87
src/pkg/net/udp_test.go
Normal file
87
src/pkg/net/udp_test.go
Normal file
|
|
@ -0,0 +1,87 @@
|
|||
// Copyright 2012 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package net
|
||||
|
||||
import (
|
||||
"runtime"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestWriteToUDP(t *testing.T) {
|
||||
if runtime.GOOS == "plan9" {
|
||||
return
|
||||
}
|
||||
|
||||
l, err := ListenPacket("udp", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
t.Fatalf("Listen failed: %v", err)
|
||||
}
|
||||
defer l.Close()
|
||||
|
||||
testWriteToConn(t, l.LocalAddr().String())
|
||||
testWriteToPacketConn(t, l.LocalAddr().String())
|
||||
}
|
||||
|
||||
func testWriteToConn(t *testing.T, raddr string) {
|
||||
c, err := Dial("udp", raddr)
|
||||
if err != nil {
|
||||
t.Fatalf("Dial failed: %v", err)
|
||||
}
|
||||
defer c.Close()
|
||||
|
||||
ra, err := ResolveUDPAddr("udp", raddr)
|
||||
if err != nil {
|
||||
t.Fatalf("ResolveUDPAddr failed: %v", err)
|
||||
}
|
||||
|
||||
_, err = c.(*UDPConn).WriteToUDP([]byte("Connection-oriented mode socket"), ra)
|
||||
if err == nil {
|
||||
t.Fatal("WriteToUDP should be failed")
|
||||
}
|
||||
if err != nil && err.(*OpError).Err != ErrWriteToConnected {
|
||||
t.Fatalf("WriteToUDP should be failed as ErrWriteToConnected: %v", err)
|
||||
}
|
||||
|
||||
_, err = c.(*UDPConn).WriteTo([]byte("Connection-oriented mode socket"), ra)
|
||||
if err == nil {
|
||||
t.Fatal("WriteTo should be failed")
|
||||
}
|
||||
if err != nil && err.(*OpError).Err != ErrWriteToConnected {
|
||||
t.Fatalf("WriteTo should be failed as ErrWriteToConnected: %v", err)
|
||||
}
|
||||
|
||||
_, err = c.Write([]byte("Connection-oriented mode socket"))
|
||||
if err != nil {
|
||||
t.Fatalf("Write failed: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func testWriteToPacketConn(t *testing.T, raddr string) {
|
||||
c, err := ListenPacket("udp", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
t.Fatalf("ListenPacket failed: %v", err)
|
||||
}
|
||||
defer c.Close()
|
||||
|
||||
ra, err := ResolveUDPAddr("udp", raddr)
|
||||
if err != nil {
|
||||
t.Fatalf("ResolveUDPAddr failed: %v", err)
|
||||
}
|
||||
|
||||
_, err = c.(*UDPConn).WriteToUDP([]byte("Connection-less mode socket"), ra)
|
||||
if err != nil {
|
||||
t.Fatalf("WriteToUDP failed: %v", err)
|
||||
}
|
||||
|
||||
_, err = c.WriteTo([]byte("Connection-less mode socket"), ra)
|
||||
if err != nil {
|
||||
t.Fatalf("WriteTo failed: %v", err)
|
||||
}
|
||||
|
||||
_, err = c.(*UDPConn).Write([]byte("Connection-less mode socket"))
|
||||
if err == nil {
|
||||
t.Fatal("Write should be failed")
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue