Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile/internal/syntax: differentiate between ';' and '\n' in syntax errors

Browse source 
Towards better syntax error messages: With this change, the parser knows whether
a semicolon was an actual ';' in the source, or whether it was an automatically
inserted semicolon as result of a '\n' or EOF. Using this information in error
messages makes them more understandable.

For #17328.

Change-Id: I8cd9accee8681b62569d0ecef922d38682b401eb
Reviewed-on: https://go-review.googlesource.com/36636
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Robert Griesemer 2017-02-08 17:30:45 -08:00
parent 4f6d4bb3f4
commit 9799622f09
5 changed files with 19 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/cmd/compile/internal/syntax/scanner_test.go
View file

@ -66,6 +66,11 @@ func TestTokens(t *testing.T) {
}
switch want.tok {
case _Semi:
if got.lit != "semicolon" {
t.Errorf("got %s; want semicolon", got.lit)
}
case _Name, _Literal:
if got.lit != want.src {
t.Errorf("got lit = %q; want %q", got.lit, want.src)
@ -94,6 +99,9 @@ func TestTokens(t *testing.T) {
t.Errorf("got tok = %s; want ;", got.tok)
continue
}
if got.lit != "newline" {
t.Errorf("got %s; want newline", got.lit)
}
}
got.next()