Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

all: delete remaining windows/arm code

Browse source 
Fixes #43800
Updates #71671

Change-Id: Ib7aafe3a3f6ae48f23fa23f03103820e9fcf5161
Reviewed-on: https://go-review.googlesource.com/c/go/+/698415
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
This commit is contained in:
Alberto Donizetti 2025-08-22 11:49:53 +02:00
parent 1ad30844d9
commit 98238fd495
4 changed files with 6 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/dist/test.go vendored
View file

@ -1773,7 +1773,7 @@ func buildModeSupported(compiler, buildmode, goos, goarch string) bool {
"ios/amd64", "ios/arm64", "ios/amd64", "ios/arm64",
"aix/ppc64", "aix/ppc64",
"openbsd/arm64", "openbsd/arm64",
"windows/386", "windows/amd64", "windows/arm", "windows/arm64": "windows/386", "windows/amd64", "windows/arm64":
return true return true
} }
return false return false

8
src/cmd/internal/obj/fips140.go
View file

@ -196,15 +196,9 @@ func EnableFIPS() bool {
// Perhaps the default should be changed back to -buildmode=exe, // Perhaps the default should be changed back to -buildmode=exe,
// after which we could remove this case, but until then, // after which we could remove this case, but until then,
// skip FIPS on windows-386. // skip FIPS on windows-386.
// if buildcfg.GOOS == "windows" && buildcfg.GOARCH == "386" {
// We don't know whether arm works, because it is too hard to get builder
// time to test it. Disable since it's not important right now.
if buildcfg.GOOS == "windows" {
switch buildcfg.GOARCH {
case "386", "arm":
return false return false
} }
}
// AIX doesn't just work, and it's not worth fixing. // AIX doesn't just work, and it's not worth fixing.
if buildcfg.GOOS == "aix" { if buildcfg.GOOS == "aix" {

1
src/crypto/internal/fips140/fips140.go
View file

@ -46,7 +46,6 @@ func Supported() error {
switch { switch {
case runtime.GOARCH == "wasm", case runtime.GOARCH == "wasm",
runtime.GOOS == "windows" && runtime.GOARCH == "386", runtime.GOOS == "windows" && runtime.GOARCH == "386",
runtime.GOOS == "windows" && runtime.GOARCH == "arm",
runtime.GOOS == "openbsd", // due to -fexecute-only, see #70880 runtime.GOOS == "openbsd", // due to -fexecute-only, see #70880
runtime.GOOS == "aix": runtime.GOOS == "aix":
return errors.New("FIPS 140-3 mode is not supported on " + runtime.GOOS + "-" + runtime.GOARCH) return errors.New("FIPS 140-3 mode is not supported on " + runtime.GOOS + "-" + runtime.GOARCH)

11
src/runtime/signal_windows_test.go
View file

@ -79,12 +79,7 @@ func TestVectoredHandlerDontCrashOnLibrary(t *testing.T) {
if *flagQuick { if *flagQuick {
t.Skip("-quick") t.Skip("-quick")
} }
if runtime.GOARCH == "arm" {
//TODO: remove this skip and update testwinlib/main.c
// once windows/arm supports c-shared buildmode.
// See go.dev/issues/43800.
t.Skip("this test can't run on windows/arm")
}
testenv.MustHaveGoBuild(t) testenv.MustHaveGoBuild(t)
testenv.MustHaveCGO(t) testenv.MustHaveCGO(t)
testenv.MustHaveExecPath(t, "gcc") testenv.MustHaveExecPath(t, "gcc")
@ -115,8 +110,8 @@ func TestVectoredHandlerDontCrashOnLibrary(t *testing.T) {
t.Fatalf("failure while running executable: %s\n%s", err, out) t.Fatalf("failure while running executable: %s\n%s", err, out)
} }
var expectedOutput string var expectedOutput string
if runtime.GOARCH == "arm64" || runtime.GOARCH == "arm" { if runtime.GOARCH == "arm64" {
// TODO: remove when windows/arm64 and windows/arm support SEH stack unwinding. // TODO: remove when windows/arm64 support SEH stack unwinding.
expectedOutput = "exceptionCount: 1\ncontinueCount: 1\nunhandledCount: 0\n" expectedOutput = "exceptionCount: 1\ncontinueCount: 1\nunhandledCount: 0\n"
} else { } else {
expectedOutput = "exceptionCount: 1\ncontinueCount: 1\nunhandledCount: 1\n" expectedOutput = "exceptionCount: 1\ncontinueCount: 1\nunhandledCount: 1\n"