Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: in cse, allow for new ssa values

Browse source 
The table of rewrites in ssa/cse is not sized appropriately for
ssa IDs that are created during copying of selects into new blocks.

Fixes #17918

Change-Id: I65fe86c6aab5efa679aa473aadc4ee6ea882cd41
Reviewed-on: https://go-review.googlesource.com/33240
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Philip Hofer 2016-11-14 17:05:46 -08:00 • committed by Cherry Zhang
parent 277bcbbdcd
commit a34fddf46c
2 changed files with 45 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/cmd/compile/internal/ssa/cse.go
View file

@ -188,7 +188,10 @@ func cse(f *Func) {
for _, b := range f.Blocks {
out:
for _, v := range b.Values {
if rewrite[v.ID] != nil {
// New values are created when selectors are copied to
// a new block. We can safely ignore those new values,
// since they have already been copied (issue 17918).
if int(v.ID) >= len(rewrite) || rewrite[v.ID] != nil {
continue
}
if v.Op != OpSelect0 && v.Op != OpSelect1 {