mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
strings,bytes: add internal docs about perennial noCopy questions
Updates #26462 Updates #25907 Updates #47276 Updates #48398 Change-Id: Ic64fc8d0c284f6e5aa383a8d417fa5768dcd7925 Reviewed-on: https://go-review.googlesource.com/c/go/+/674096 Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
parent
bd29985212
commit
a74ae95282
2 changed files with 12 additions and 0 deletions
|
|
@ -21,6 +21,12 @@ type Buffer struct {
|
|||
buf []byte // contents are the bytes buf[off : len(buf)]
|
||||
off int // read at &buf[off], write at &buf[len(buf)]
|
||||
lastRead readOp // last read operation, so that Unread* can work correctly.
|
||||
|
||||
// Copying and modifying a non-zero Buffer is prone to error,
|
||||
// but we cannot employ the noCopy trick used by WaitGroup and Mutex,
|
||||
// which causes vet's copylocks checker to report misuse, as vet
|
||||
// cannot reliably distinguish the zero and non-zero cases.
|
||||
// See #26462, #25907, #47276, #48398 for history.
|
||||
}
|
||||
|
||||
// The readOp constants describe the last action performed on
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue