runtime: replace os.MkdirTemp with T.TempDir

Updates #45402

Change-Id: I3aa82fc2486b4de49b45388bbab24f5ffe558f91
Reviewed-on: https://go-review.googlesource.com/c/go/+/307989
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Tobias Klauser <tobias.klauser@gmail.com>
This commit is contained in:
ianwoolf 2021-04-07 20:16:58 +08:00 committed by Emmanuel Odeke
parent 2123dfba65
commit a7e16abb22
7 changed files with 31 additions and 113 deletions

View file

@ -169,11 +169,7 @@ func testGdbPython(t *testing.T, cgo bool) {
checkGdbVersion(t)
checkGdbPython(t)
dir, err := os.MkdirTemp("", "go-build")
if err != nil {
t.Fatalf("failed to create temp directory: %v", err)
}
defer os.RemoveAll(dir)
dir := t.TempDir()
var buf bytes.Buffer
buf.WriteString("package main\n")
@ -194,7 +190,7 @@ func testGdbPython(t *testing.T, cgo bool) {
}
}
err = os.WriteFile(filepath.Join(dir, "main.go"), src, 0644)
err := os.WriteFile(filepath.Join(dir, "main.go"), src, 0644)
if err != nil {
t.Fatalf("failed to create file: %v", err)
}
@ -403,15 +399,11 @@ func TestGdbBacktrace(t *testing.T) {
t.Parallel()
checkGdbVersion(t)
dir, err := os.MkdirTemp("", "go-build")
if err != nil {
t.Fatalf("failed to create temp directory: %v", err)
}
defer os.RemoveAll(dir)
dir := t.TempDir()
// Build the source code.
src := filepath.Join(dir, "main.go")
err = os.WriteFile(src, []byte(backtraceSource), 0644)
err := os.WriteFile(src, []byte(backtraceSource), 0644)
if err != nil {
t.Fatalf("failed to create file: %v", err)
}
@ -481,15 +473,11 @@ func TestGdbAutotmpTypes(t *testing.T) {
t.Skip("TestGdbAutotmpTypes is too slow on aix/ppc64")
}
dir, err := os.MkdirTemp("", "go-build")
if err != nil {
t.Fatalf("failed to create temp directory: %v", err)
}
defer os.RemoveAll(dir)
dir := t.TempDir()
// Build the source code.
src := filepath.Join(dir, "main.go")
err = os.WriteFile(src, []byte(autotmpTypeSource), 0644)
err := os.WriteFile(src, []byte(autotmpTypeSource), 0644)
if err != nil {
t.Fatalf("failed to create file: %v", err)
}
@ -550,15 +538,11 @@ func TestGdbConst(t *testing.T) {
t.Parallel()
checkGdbVersion(t)
dir, err := os.MkdirTemp("", "go-build")
if err != nil {
t.Fatalf("failed to create temp directory: %v", err)
}
defer os.RemoveAll(dir)
dir := t.TempDir()
// Build the source code.
src := filepath.Join(dir, "main.go")
err = os.WriteFile(src, []byte(constsSource), 0644)
err := os.WriteFile(src, []byte(constsSource), 0644)
if err != nil {
t.Fatalf("failed to create file: %v", err)
}
@ -617,15 +601,11 @@ func TestGdbPanic(t *testing.T) {
t.Parallel()
checkGdbVersion(t)
dir, err := os.MkdirTemp("", "go-build")
if err != nil {
t.Fatalf("failed to create temp directory: %v", err)
}
defer os.RemoveAll(dir)
dir := t.TempDir()
// Build the source code.
src := filepath.Join(dir, "main.go")
err = os.WriteFile(src, []byte(panicSource), 0644)
err := os.WriteFile(src, []byte(panicSource), 0644)
if err != nil {
t.Fatalf("failed to create file: %v", err)
}
@ -695,15 +675,11 @@ func TestGdbInfCallstack(t *testing.T) {
t.Parallel()
checkGdbVersion(t)
dir, err := os.MkdirTemp("", "go-build")
if err != nil {
t.Fatalf("failed to create temp directory: %v", err)
}
defer os.RemoveAll(dir)
dir := t.TempDir()
// Build the source code.
src := filepath.Join(dir, "main.go")
err = os.WriteFile(src, []byte(InfCallstackSource), 0644)
err := os.WriteFile(src, []byte(InfCallstackSource), 0644)
if err != nil {
t.Fatalf("failed to create file: %v", err)
}