Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/go: fix TestScript/tool_build_as_needed

Browse source 
This test assumes that changing GOOS/GOARCH results in an
unrunnable binary, but that's not true if the user has
go_GOOS_GOARCH_exec programs in their path (like I do).
This test was timing out waiting to create a gomote to run
a windows/amd64 binary.

Rewrite the test not to assume that alternate GOOS/GOARCH
binaries are unrunnable.

Fixes one failing case in 'go test cmd/go' on my Mac.

Change-Id: Ib5f721f91e10d285820efb5995a3a9bc29833214
Reviewed-on: https://go-review.googlesource.com/c/go/+/718180
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Michael Matloob <matloob@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
This commit is contained in:
Russ Cox 2025-11-05 14:05:45 -05:00 • committed by Gopher Robot
parent 04f05219c4
commit a8fb94969c
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/cmd/go/testdata/script/tool_build_as_needed.txt vendored
View file

@ -40,13 +40,15 @@ rm $TOOLDIR/test2json$GOEXE
go tool -n test2json go tool -n test2json
! stdout $NEWTOOLDIR${/}test2json$GOEXE ! stdout $NEWTOOLDIR${/}test2json$GOEXE
# Set GOOS/GOARCH to different values than host GOOS/GOARCH. # Set GOOS/GOARCH to different values than host GOOS/GOARCH.
env GOOS=windows env GOOS=js
[GOOS:windows] env GOOS=linux env GOARCH=wasm
env GOARCH=arm64
[GOARCH:arm64] env GOARCH=amd64
# Control case: go run shouldn't work because it respects # Control case: go run shouldn't work because it respects
# GOOS/GOARCH, and we can't execute non-native binary. # GOOS/GOARCH, and we can't execute non-native binary.
! go run cmd/test2json -exec='' # Don't actually run the binary because maybe we can.
# But go tool should because it doesn't respect GOOS/GOARCH. # (Maybe the user has a go_js_wasm_exec installed.)
# Instead just look to see that the right binary got linked.
go run -n cmd/test2json
stderr modinfo.*GOARCH=wasm.*GOOS=js
# go tool should succeed because it doesn't respect GOOS/GOARCH.
go tool test2json go tool test2json
stdout '{"Action":"start"}' stdout '{"Action":"start"}'