Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: bump thread count slack for TestReadMetricsSched

Browse source 
This test is *still* flaky, but it appears to be just
mayMoreStackPreempt and the thread count *occasionally* exceeds the
original (and arbitrary) thread count slack by exactly 1.

Bump the thread count slack by one. We can investigate further and bump
it again if it continues to be a problem.

Fixes #75664.

Change-Id: I29c922bba6d2cc99a8c3bf5e04cc512d0694f7fa
Reviewed-on: https://go-review.googlesource.com/c/go/+/708868
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Anthony Knyszek 2025-10-03 16:23:10 +00:00 • committed by Gopher Robot
parent e74b224b7c
commit ac2ec82172
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/runtime/testdata/testprog/schedmetrics.go vendored
View file

@ -84,7 +84,12 @@ func SchedMetrics() {
// threadsSlack is the maximum number of threads left over
// from the runtime (sysmon, the template thread, etc.)
const threadsSlack = 4
// Certain build modes may also cause the creation of additional
// threads through frequent scheduling, like mayMoreStackPreempt.
// A slack of 5 is arbitrary but appears to be enough to cover
// the leftovers plus any inflation from scheduling-heavy build
// modes.
const threadsSlack = 5
// Make sure GC isn't running, since GC workers interfere with
// expected counts.