Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: restore caller's frame pointer when recovering from panic

Browse source 
When recovering from a panic, restore the caller's frame pointer before
returning control to the caller. Otherwise, if the function proceeds to
run more deferred calls before returning, the deferred functions will
get invalid frame pointers pointing to an address lower in the stack.
This can cause frame pointer unwinding to crash, such as if an execution
trace event is recorded during the deferred call on architectures which
support frame pointer unwinding.

Fixes #61766

Change-Id: I45f41aedcc397133560164ab520ca638bbd93c4e
Reviewed-on: https://go-review.googlesource.com/c/go/+/516157
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
This commit is contained in:
Nick Ripley 2023-08-04 17:31:43 -04:00 • committed by Michael Knyszek
parent 94d36fbc4a
commit b51a4dd6c4
3 changed files with 49 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/runtime/export_test.go
View file

@ -1922,6 +1922,8 @@ func FPCallers(pcBuf []uintptr) int {
return fpTracebackPCs(unsafe.Pointer(getfp()), pcBuf)
}
const FramePointerEnabled = framepointer_enabled
var (
IsPinned = isPinned
GetPinCounter = pinnerGetPinCounter