Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: create "init" symbol earlier

Browse source 
We create the "init" symbol and mark it as a function before compiling
to SSA because SSA can initialize this symbol, but it turns out we do
it slightly too late. peekitabs, at least, can also create the "init"
LSym. Move this initialization to just after type-checking.

Fixes the linux-amd64-ssacheck and the android-arm64-wiko-fever
builders.

Updates #27539.

Change-Id: If145952c79d39f75c93b24e35e67fe026dd08329
Reviewed-on: https://go-review.googlesource.com/c/149137
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Austin Clements 2018-11-12 16:31:47 -05:00
parent 891f99eb43
commit b52db19b98
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/cmd/compile/internal/gc/main.go
View file

@ -557,6 +557,11 @@ func Main(archInit func(*Arch)) {
errorexit()
}
// The "init" function is the only user-spellable symbol that
// we construct later. Mark it as a function now before
// anything can ask for its Linksym.
lookup("init").SetFunc(true)
// Phase 4: Decide how to capture closed variables.
// This needs to run before escape analysis,
// because variables captured by value do not escape.
@ -649,11 +654,6 @@ func Main(archInit func(*Arch)) {
Curfn = nil
peekitabs()
// The "init" function is the only user-spellable symbol that
// we construct later. Mark it as a function now before
// anything can ask for its Linksym.
lookup("init").SetFunc(true)
// Phase 8: Compile top level functions.
// Don't use range--walk can add functions to xtop.
timings.Start("be", "compilefuncs")