Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: remove period from "not allowed in runtime" errors

Browse source 
We don't punctuate compiler diagnostics.

Change-Id: I19e1f30fbf04f0d1bfe6648fae26beaf3a06ee92
Reviewed-on: https://go-review.googlesource.com/c/go/+/201077
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Matthew Dempsky 2019-10-14 12:16:52 -07:00
parent 06b12e660c
commit b649bdc7f3
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/gc/closure.go
View file

@ -345,7 +345,7 @@ func closuredebugruntimecheck(clo *Node) {
} }
} }
if compiling_runtime && clo.Esc == EscHeap { if compiling_runtime && clo.Esc == EscHeap {
yyerrorl(clo.Pos, "heap-allocated closure, not allowed in runtime.") yyerrorl(clo.Pos, "heap-allocated closure, not allowed in runtime")
} }
} }

2
src/cmd/compile/internal/gc/esc.go
View file

@ -251,7 +251,7 @@ func moveToHeap(n *Node) {
Dump("MOVE", n) Dump("MOVE", n)
} }
if compiling_runtime { if compiling_runtime {
yyerror("%v escapes to heap, not allowed in runtime.", n) yyerror("%v escapes to heap, not allowed in runtime", n)
} }
if n.Class() == PAUTOHEAP { if n.Class() == PAUTOHEAP {
Dump("n", n) Dump("n", n)

2
src/cmd/compile/internal/gc/walk.go
View file

@ -195,7 +195,7 @@ func walkstmt(n *Node) *Node {
v := n.Left v := n.Left
if v.Class() == PAUTOHEAP { if v.Class() == PAUTOHEAP {
if compiling_runtime { if compiling_runtime {
yyerror("%v escapes to heap, not allowed in runtime.", v) yyerror("%v escapes to heap, not allowed in runtime", v)
} }
if prealloc[v] == nil { if prealloc[v] == nil {
prealloc[v] = callnew(v.Type) prealloc[v] = callnew(v.Type)

6
test/fixedbugs/issue14999.go
View file

@ -7,11 +7,11 @@
package p package p
func f(x int) func(int) int { func f(x int) func(int) int {
return func(y int) int { return x + y } // ERROR "heap-allocated closure, not allowed in runtime." return func(y int) int { return x + y } // ERROR "heap-allocated closure, not allowed in runtime"
} }
func g(x int) func(int) int { // ERROR "x escapes to heap, not allowed in runtime." func g(x int) func(int) int { // ERROR "x escapes to heap, not allowed in runtime"
return func(y int) int { // ERROR "heap-allocated closure, not allowed in runtime." return func(y int) int { // ERROR "heap-allocated closure, not allowed in runtime"
x += y x += y
return x + y return x + y
} }