mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
[dev.cc] runtime: allow more address bits in lfstack on Power64
Previously, lfstack assumed Linux limited user space addresses to 43 bits on Power64 based on a paper from 2001. It turns out the limit is now 46 bits, so lfstack was truncating pointers. Raise the limit to 48 bits (for some future proofing and to make it match amd64) and add a self-test that will fail in a useful way if ever unpack(pack(x)) != x. With this change, dev.cc passes all.bash on power64le. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/174430043
This commit is contained in:
parent
b27c0618eb
commit
b76e836042
2 changed files with 17 additions and 7 deletions
|
|
@ -12,6 +12,10 @@ import "unsafe"
|
|||
func lfstackpush(head *uint64, node *lfnode) {
|
||||
node.pushcnt++
|
||||
new := lfstackPack(node, node.pushcnt)
|
||||
if node1, _ := lfstackUnpack(new); node1 != node {
|
||||
println("runtime: lfstackpush invalid packing: node=", node, " cnt=", hex(node.pushcnt), " packed=", hex(new), " -> node=", node1, "\n")
|
||||
gothrow("lfstackpush")
|
||||
}
|
||||
for {
|
||||
old := atomicload64(head)
|
||||
node.next, _ = lfstackUnpack(old)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue