Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

internal/trace: remove redundant info from Event.String

Browse source 
Remove redundant information from state transition events. They
currently mention the proc and goroutine id that is transitioning twice.

Also reorder the reason to appear after the from->to state transition
information since it is a detail that is not available for all
transition.

Before example:

M=6164541440 P=3 G=17 StateTransition Time=7169014471424 Resource=Goroutine(17) Reason="chan receive" GoID=17 Running->Waiting
M=6166261760 P=3 G=10 StateTransition Time=7169908799040 Resource=Proc(4) Reason="" ProcID=4 Idle->Idle

After example:

M=6164541440 P=3 G=17 StateTransition Time=7169014471424 GoID=17 Running->Waiting Reason="chan receive" 
M=6166261760 P=3 G=10 StateTransition Time=7169908799040 ProcID=4 Idle->Idle Reason=""

Change-Id: I6a6a696487ff2905f7c98dae7e887b998a2cb298
Reviewed-on: https://go-review.googlesource.com/c/go/+/697356
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This commit is contained in:
Felix Geisendörfer 2025-08-19 17:17:03 +02:00 • committed by Gopher Robot
parent c7d8bda459
commit b80ffb64d8
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/internal/trace/event.go
View file

@ -843,7 +843,6 @@ func (e Event) String() string {
fmt.Fprintf(&sb, " Task=%d Category=%q Message=%q", l.Task, l.Category, l.Message) fmt.Fprintf(&sb, " Task=%d Category=%q Message=%q", l.Task, l.Category, l.Message)
case EventStateTransition: case EventStateTransition:
s := e.StateTransition() s := e.StateTransition()
fmt.Fprintf(&sb, " Resource=%s Reason=%q", s.Resource, s.Reason)
switch s.Resource.Kind { switch s.Resource.Kind {
case ResourceGoroutine: case ResourceGoroutine:
id := s.Resource.Goroutine() id := s.Resource.Goroutine()
@ -854,6 +853,7 @@ func (e Event) String() string {
old, new := s.Proc() old, new := s.Proc()
fmt.Fprintf(&sb, " ProcID=%d %s->%s", id, old, new) fmt.Fprintf(&sb, " ProcID=%d %s->%s", id, old, new)
} }
fmt.Fprintf(&sb, " Reason=%q", s.Reason)
if s.Stack != NoStack { if s.Stack != NoStack {
fmt.Fprintln(&sb) fmt.Fprintln(&sb)
fmt.Fprintln(&sb, "TransitionStack=") fmt.Fprintln(&sb, "TransitionStack=")