Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-11-02 01:30:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: remove redundant cgoLookupCNAME return parameter

Browse source 
`completed bool` just means `err == nil` after CL 446179.

While here, add a test for cgoLookupCNAME.

Co-authored-by: Mateusz Poliwczak <mpoliwczak34@gmail.com>
Change-Id: I6081a089fde3cb27af4fbde6f04301fc3755272c
Reviewed-on: https://go-review.googlesource.com/c/go/+/698615
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Sean Liao <sean@liao.dev>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Sean Liao <sean@liao.dev>
Reviewed-by: Mateusz Poliwczak <mpoliwczak34@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
database64128 2025-08-23 04:55:42 +08:00 • committed by Gopher Robot
parent f74ed44ed9
commit ba1109feb5
4 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/net/cgo_unix_test.go
View file

@ -8,6 +8,7 @@ package net
import (
"context"
"internal/testenv"
"testing"
)
@ -67,3 +68,12 @@ func TestCgoLookupPTRWithCancel(t *testing.T) {
t.Error(err)
}
}
func TestCgoLookupCNAME(t *testing.T) {
mustHaveExternalNetwork(t)
testenv.SkipFlakyNet(t)
defer dnsWaitGroup.Wait()
if _, err := cgoLookupCNAME(t.Context(), "www.iana.org."); err != nil {
t.Error(err)
}
}