Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: skip generating args_stackmap for "pulled" funcs

Browse source 
In golang.org/cl/171464, we cleaned up generation of .stkobj linker
symbols, but we couldn't figure out why a similar cleanup to
.args_stackmap linker symbols caused problems.

The issue is that we only need/want to generate .args_stackmap for
functions that are implemented in assembly in the same package. When
"pulling" a function from another package via //go:linkname, we can
safely skip emitting .args_stackmap, because compiling that package
will have generated it, if necessary.

Fixes #31615.

Change-Id: If8680aa7dd5b4e8f268b6b032d746f1b8536c867
Reviewed-on: https://go-review.googlesource.com/c/go/+/223238
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Matthew Dempsky 2020-03-12 12:14:02 -07:00
parent 0c30245996
commit bb929b7452
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/compile/internal/gc/pgen.go
View file

@ -12,7 +12,6 @@ import (
"cmd/internal/objabi" "cmd/internal/objabi"
"cmd/internal/src" "cmd/internal/src"
"cmd/internal/sys" "cmd/internal/sys"
"fmt"
"internal/race" "internal/race"
"math/rand" "math/rand"
"sort" "sort"
@ -28,11 +27,10 @@ var (
) )
func emitptrargsmap(fn *Node) { func emitptrargsmap(fn *Node) {
if fn.funcname() == "_" { if fn.funcname() == "_" || fn.Func.Nname.Sym.Linkname != "" {
return return
} }
sym := lookup(fmt.Sprintf("%s.args_stackmap", fn.funcname())) lsym := Ctxt.Lookup(fn.Func.lsym.Name + ".args_stackmap")
lsym := sym.Linksym()
nptr := int(fn.Type.ArgWidth() / int64(Widthptr)) nptr := int(fn.Type.ArgWidth() / int64(Widthptr))
bv := bvalloc(int32(nptr) * 2) bv := bvalloc(int32(nptr) * 2)