Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-10-19 11:03:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/distpack: use positive list of tools to keep

Browse source 
Previously, distpack filtered out tools from the packaged distribution
using a list of tools to remove. Instead follow mpratt's suggestion on
CL 666755 and instead filter out tools that are not on a list of tools
to keep. This will make it easier to tell which tools are actually in
the distribution.

For #71867

Change-Id: I8336465703ac820028c3381a0a743c457997e78a
Reviewed-on: https://go-review.googlesource.com/c/go/+/673696
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Matloob <matloob@google.com>
This commit is contained in:
Michael Matloob 2025-05-16 19:53:21 -04:00 • committed by Michael Matloob
parent 198c3cb785
commit bd29985212
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/distpack/pack.go
View file

@ -167,11 +167,11 @@ func main() {
if !strings.HasPrefix(name, "pkg/tool/"+goosUnderGoarch+"/") {
return false
}
// Inside pkg/tool/$GOOS_$GOARCH, discard helper tools, and tools not needed for builds.
// Inside pkg/tool/$GOOS_$GOARCH, keep only tools needed for build actions.
switch strings.TrimSuffix(path.Base(name), ".exe") {
case "addr2line", "api", "buildid", "covdata", "dist", "distpack", "doc", "fix",
"metadata", "nm", "objdump", "pprof", "test2json", "trace":
default:
return false
case "asm", "cgo", "compile", "cover", "link", "pack", "preprofile", "vet":
}
}
return true