Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

testing: explain how SkipNow and FailNow stop execution

Browse source 
SkipNow and FailNow must be called from the goroutine running the
test. This is already documented, but it's easy to call them by
mistake when writing subtests. In the following:

  func TestPanic(t *testing.T) {
    t.Run("", func(t2 *testing.T) {
	  t.FailNow()    // BAD: should be t2.FailNow()
	})
  }

the FailNow call on the outer t *testing.T correctly triggers a panic

  panic: test executed panic(nil) or runtime.Goexit

The error message confuses users (see issues #17421, #21175) because
there is no way to trace back the relevant part of the message ("test
executed ... runtime.Goexit") to a bad FailNow call without checking
the testing package source code and finding out that FailNow calls
runtime.Goexit.

To help users debug the panic message, mention in the SkipNow and
FailNow documentation that they stop execution by calling
runtime.Goexit.

Fixes #21175

Change-Id: I0a3e5f768e72b464474380cfffbf2b67396ac1b5
Reviewed-on: https://go-review.googlesource.com/52770
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Alberto Donizetti 2017-08-02 18:22:21 +02:00
parent 6b6b9f69fd
commit bd74fd3abb
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/testing/testing.go
View file

@ -512,7 +512,8 @@ func (c *common) Failed() bool {
return failed || c.raceErrors+race.Errors() > 0 return failed || c.raceErrors+race.Errors() > 0
} }
// FailNow marks the function as having failed and stops its execution. // FailNow marks the function as having failed and stops its execution
// by calling runtime.Goexit.
// Execution will continue at the next test or benchmark. // Execution will continue at the next test or benchmark.
// FailNow must be called from the goroutine running the // FailNow must be called from the goroutine running the
// test or benchmark function, not from other goroutines // test or benchmark function, not from other goroutines
@ -600,7 +601,8 @@ func (c *common) Skipf(format string, args ...interface{}) {
c.SkipNow() c.SkipNow()
} }
// SkipNow marks the test as having been skipped and stops its execution. // SkipNow marks the test as having been skipped and stops its execution
// by calling runtime.Goexit.
// If a test fails (see Error, Errorf, Fail) and is then skipped, // If a test fails (see Error, Errorf, Fail) and is then skipped,
// it is still considered to have failed. // it is still considered to have failed.
// Execution will continue at the next test or benchmark. See also FailNow. // Execution will continue at the next test or benchmark. See also FailNow.