Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

bytes,strings,unicode/utf16: use slices to clean up tests

Browse source 
Replace reflect.DeepEqual with slices.Equal, which is much faster.
Remove some redundant helper functions.

Change-Id: I51b32a3d0c3fc5ad0d3b6ff0dd03f39c507e5762
GitHub-Last-Rev: e21f46d4a0
GitHub-Pull-Request: golang/go#67609
Reviewed-on: https://go-review.googlesource.com/c/go/+/587937
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <gri@google.com>
This commit is contained in:
apocelipes 2024-07-24 10:32:22 +00:00 • committed by Robert Griesemer
parent 910e6b5fae
commit c0eac35a4c
4 changed files with 16 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/strings/strings_test.go
View file

@ -10,7 +10,7 @@ import (
"io"
"math"
"math/rand"
"reflect"
"slices"
"strconv"
. "strings"
"testing"
@ -431,7 +431,7 @@ func TestSplit(t *testing.T) {
}
if tt.n < 0 {
b := Split(tt.s, tt.sep)
if !reflect.DeepEqual(a, b) {
if !slices.Equal(a, b) {
t.Errorf("Split disagrees with SplitN(%q, %q, %d) = %v; want %v", tt.s, tt.sep, tt.n, b, a)
}
}
@ -467,7 +467,7 @@ func TestSplitAfter(t *testing.T) {
}
if tt.n < 0 {
b := SplitAfter(tt.s, tt.sep)
if !reflect.DeepEqual(a, b) {
if !slices.Equal(a, b) {
t.Errorf("SplitAfter disagrees with SplitAfterN(%q, %q, %d) = %v; want %v", tt.s, tt.sep, tt.n, b, a)
}
}