diff --git a/src/go/types/api_test.go b/src/go/types/api_test.go index 6998fc0a0d5..3438d790246 100644 --- a/src/go/types/api_test.go +++ b/src/go/types/api_test.go @@ -1430,6 +1430,9 @@ func TestConvertibleTo(t *testing.T) { {newDefined(new(Struct)), new(Struct), true}, {newDefined(Typ[Int]), new(Struct), false}, {Typ[UntypedInt], Typ[Int], true}, + {NewSlice(Typ[Int]), NewPointer(NewArray(Typ[Int], 10)), true}, + {NewSlice(Typ[Int]), NewArray(Typ[Int], 10), false}, + {NewSlice(Typ[Int]), NewPointer(NewArray(Typ[Uint], 10)), false}, // Untyped string values are not permitted by the spec, so the below // behavior is undefined. {Typ[UntypedString], Typ[String], true}, diff --git a/src/go/types/conversions.go b/src/go/types/conversions.go index d93ff465bb8..e977d0db1f5 100644 --- a/src/go/types/conversions.go +++ b/src/go/types/conversions.go @@ -133,6 +133,18 @@ func (x *operand) convertibleTo(check *Checker, T Type) bool { return true } + // "x is a slice, T is a pointer-to-array type, + // and the slice and array types have identical element types." + if s := asSlice(V); s != nil { + if p := asPointer(T); p != nil { + if a := asArray(p.Elem()); a != nil { + if check.identical(s.Elem(), a.Elem()) { + return true + } + } + } + } + return false } diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go index 8f9218c864a..29f71137df8 100644 --- a/src/go/types/stdlib_test.go +++ b/src/go/types/stdlib_test.go @@ -163,10 +163,6 @@ func TestStdTest(t *testing.T) { "embedfunc.go", // tests //go:embed "embedvers.go", // tests //go:embed "linkname2.go", // go/types doesn't check validity of //go:xxx directives - - "convert2.go", // temporary: go/types doesn't know yet about converting from slices to array pointers - "convert4.go", // temporary: go/types doesn't know yet about converting from slices to array pointers - "escape_slice.go", // temporary: go/types doesn't know yet about converting from slices to array pointers ) }