Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

math/big: apply a round of go vet

Browse source 
Change-Id: Ie8310acc783659497e50dfe629f06d655b51d647
Reviewed-on: https://go-review.googlesource.com/5990
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Robert Griesemer 2015-02-25 10:20:28 -08:00
parent bba8b89aa5
commit c20a018d6f
2 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/math/big/float.go
View file

@ -292,7 +292,7 @@ func validate(x *Float) {
if m == 0 { if m == 0 {
// 0.0 or Inf // 0.0 or Inf
if x.exp != 0 && x.exp != infExp { if x.exp != 0 && x.exp != infExp {
panic(fmt.Sprintf("%empty matissa with invalid exponent %d", x.exp)) panic(fmt.Sprintf("empty matissa with invalid exponent %d", x.exp))
} }
return return
} }
@ -842,7 +842,7 @@ func (x *Float) Int(z *Int) (*Int, Accuracy) {
return z, acc return z, acc
} }
// Rat returns the result of converting x into a quotient; // Rat returns the rational number corresponding to x;
// or nil if x is an infinity. // or nil if x is an infinity.
// If a non-nil *Rat argument z is provided, Rat stores // If a non-nil *Rat argument z is provided, Rat stores
// the result in z instead of allocating a new Rat. // the result in z instead of allocating a new Rat.

20
src/math/big/int_test.go
View file

@ -290,15 +290,6 @@ func TestDivisionSigns(t *testing.T) {
} }
} }
var bitsTests = []nat{
nil,
{0},
{1},
{0, 1, 2, 3, 4},
{4, 3, 2, 1, 0},
{4, 3, 2, 1, 0, 0, 0, 0},
}
func norm(x nat) nat { func norm(x nat) nat {
i := len(x) i := len(x)
for i > 0 && x[i-1] == 0 { for i > 0 && x[i-1] == 0 {
@ -308,7 +299,14 @@ func norm(x nat) nat {
} }
func TestBits(t *testing.T) { func TestBits(t *testing.T) {
for _, test := range bitsTests { for _, test := range []nat{
nil,
{0},
{1},
{0, 1, 2, 3, 4},
{4, 3, 2, 1, 0},
{4, 3, 2, 1, 0, 0, 0, 0},
} {
var z Int var z Int
z.neg = true z.neg = true
got := z.SetBits(test) got := z.SetBits(test)
@ -318,7 +316,7 @@ func TestBits(t *testing.T) {
} }
if got.neg { if got.neg {
t.Errorf("SetBits(%v): got negative result") t.Errorf("SetBits(%v): got negative result", test)
} }
bits := nat(z.Bits()) bits := nat(z.Bits())