Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.typeparams] cmd/compile: refactor CaptureName

Browse source 
CaptureName currently does a few things: checks if a variable needs to
be captured at all; checks if the variable has already been captured;
and creates and saves a new variable. This full suite of functionality
is useful for noder and irgen, but unified IR and other backend code
only has a need for the last feature.

This CL refactors CaptureName a little bit and extracts out
NewClosureVar as a function usable for callers that don't need the
extra features of CaptureName.

Change-Id: I8a67c6375e44babe53344bf78e335535c57f9607
Reviewed-on: https://go-review.googlesource.com/c/go/+/330193
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
Matthew Dempsky 2021-06-22 18:10:59 -07:00
parent 62095c66e0
commit c4e0c652fb
2 changed files with 33 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/cmd/compile/internal/noder/reader.go
View file

@ -1558,20 +1558,13 @@ func (r *reader) funcLit() ir.Node {
fn.Nname.Ntype = ir.TypeNodeAt(typPos, xtype2)
}
fn.ClosureVars = make([]*ir.Name, r.len())
for i := range fn.ClosureVars {
fn.ClosureVars = make([]*ir.Name, 0, r.len())
for len(fn.ClosureVars) < cap(fn.ClosureVars) {
pos := r.pos()
outer := r.useLocal()
cv := ir.NewNameAt(pos, outer.Sym())
cv := ir.NewClosureVar(pos, fn, outer)
r.setType(cv, outer.Type())
cv.Curfn = fn
cv.Class = ir.PAUTOHEAP
cv.SetIsClosureVar(true)
cv.Defn = outer.Canonical()
cv.Outer = outer
fn.ClosureVars[i] = cv
}
r.addBody(fn)