Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: remove flaky TestInvalidptrCrash to fix build

Browse source 
This test fails on arm64 and some amd64 OSs and fails on Linux/amd64
if you remove the first runtime.GC(), which should be unnecessary, and
run it in all.bash (but not if you run it in isolation). I don't
understand any of these failures, so for now just remove this test.

TBR=rlh

Change-Id: Ibed00671126000ed7dc5b5d4af1f86fe4a1e30e1
Reviewed-on: https://go-review.googlesource.com/14767
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Austin Clements 2015-09-18 21:17:07 -04:00
parent 97b64d88eb
commit c742ff6adc
1 changed files with 0 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/runtime/crash_test.go
View file

@ -587,40 +587,3 @@ func main() {
fmt.Println("done") fmt.Println("done")
} }
` `
func TestInvalidptrCrash(t *testing.T) {
output := executeTest(t, invalidptrCrashSource, nil)
// Check that the bad pointer was detected.
want1 := "found bad pointer in Go heap"
if !strings.Contains(output, want1) {
t.Fatalf("failed to detect bad pointer; output does not contain %q:\n%s", want1, output)
}
// Check that we dumped the object containing the bad pointer.
want2 := "*(object+0) = 0x12345678"
if !strings.Contains(output, want2) {
t.Fatalf("failed to dump source object; output does not contain %q:\n%s", want2, output)
}
}
const invalidptrCrashSource = `
package main
import (
"runtime"
"unsafe"
)
var x = new(struct {
magic uintptr
y *byte
})
func main() {
runtime.GC()
x.magic = 0x12345678
x.y = &make([]byte, 64*1024)[0]
weasel := uintptr(unsafe.Pointer(x.y))
x.y = nil
runtime.GC()
x.y = (*byte)(unsafe.Pointer(weasel))
runtime.GC()
println("failed to detect bad pointer")
}
`