Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime/coverage: add support for "auxiliary" meta-data files

Browse source 
Enhance the functions called by _testmain.go during "go test -cover"
test binary runs to allow for injection of extra or "auxiliary"
meta-data files when reporting coverage statistics. There are unit
tests for this functionality, but it is not yet wired up to be used by
the Go command yet, that will appear in a subsequent patch.

Change-Id: I10b79ca003fd7a875727dc1a86f23f58d6bf630c
Reviewed-on: https://go-review.googlesource.com/c/go/+/495451
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Than McIntosh 2023-05-15 13:22:39 -04:00
parent ef67022471
commit c99d966c17
4 changed files with 173 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

46
src/runtime/coverage/testsupport.go
View file

@ -5,6 +5,7 @@
package coverage
import (
"encoding/json"
"fmt"
"internal/coverage"
"internal/coverage/calloc"
@ -15,6 +16,7 @@ import (
"internal/coverage/pods"
"io"
"os"
"path/filepath"
"runtime/internal/atomic"
"strings"
"unsafe"
@ -88,11 +90,19 @@ func processCoverTestDirInternal(dir string, cfile string, cm string, cpkg strin
// hash (just in case there are multiple instrumented executables
// in play). See issue #57924 for more on this.
hashstring := fmt.Sprintf("%x", finalHash)
importpaths := make(map[string]struct{})
for _, p := range podlist {
if !strings.Contains(p.MetaFile, hashstring) {
continue
}
if err := ts.processPod(p); err != nil {
if err := ts.processPod(p, importpaths); err != nil {
return err
}
}
metafilespath := filepath.Join(dir, coverage.MetaFilesFileName)
if _, err := os.Stat(metafilespath); err == nil {
if err := ts.readAuxMetaFiles(metafilespath, importpaths); err != nil {
return err
}
}
@ -124,7 +134,7 @@ type tstate struct {
}
// processPod reads coverage counter data for a specific pod.
func (ts *tstate) processPod(p pods.Pod) error {
func (ts *tstate) processPod(p pods.Pod, importpaths map[string]struct{}) error {
// Open meta-data file
f, err := os.Open(p.MetaFile)
if err != nil {
@ -204,6 +214,7 @@ func (ts *tstate) processPod(p pods.Pod) error {
return fmt.Errorf("reading pkg %d from meta-file %s: %s", pkIdx, p.MetaFile, err)
}
ts.cf.SetPackage(pd.PackagePath())
importpaths[pd.PackagePath()] = struct{}{}
var fd coverage.FuncDesc
nf := pd.NumFuncs()
for fnIdx := uint32(0); fnIdx < nf; fnIdx++ {
@ -235,6 +246,37 @@ type pkfunc struct {
pk, fcn uint32
}
func (ts *tstate) readAuxMetaFiles(metafiles string, importpaths map[string]struct{}) error {
// Unmarshall the information on available aux metafiles into
// a MetaFileCollection struct.
var mfc coverage.MetaFileCollection
data, err := os.ReadFile(metafiles)
if err != nil {
return fmt.Errorf("error reading auxmetafiles file %q: %v", metafiles, err)
}
if err := json.Unmarshal(data, &mfc); err != nil {
return fmt.Errorf("error reading auxmetafiles file %q: %v", metafiles, err)
}
// Walk through each available aux meta-file. If we've already
// seen the package path in question during the walk of the
// "regular" meta-data file, then we can skip the package,
// otherwise construct a dummy pod with the single meta-data file
// (no counters) and invoke processPod on it.
for i := range mfc.ImportPaths {
p := mfc.ImportPaths[i]
if _, ok := importpaths[p]; ok {
continue
}
var pod pods.Pod
pod.MetaFile = mfc.MetaFileFragments[i]
if err := ts.processPod(pod, importpaths); err != nil {
return err
}
}
return nil
}
// snapshot returns a snapshot of coverage percentage at a moment of
// time within a running test, so as to support the testing.Coverage()
// function. This version doesn't examine coverage meta-data, so the