Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/internal/testdir: remove temp files

Browse source 
Function stdlibImportcfgFile creates a temporary directory and a file in
it, which are never deleted.

The easiest to fix this (without creating the file unnecessarily, or
creating it multiple times) is to add a global tmpDir and use it in
stdlibImportcfgFile.

Change-Id: Ia971b4478d9e0fa7c3a9b4c66e13fd5a4af9cbaa
Reviewed-on: https://go-review.googlesource.com/c/go/+/610818
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Kir Kolyshkin 2024-09-04 22:40:31 -07:00 • committed by Gopher Robot
parent 2b832b4296
commit ca2cb8d7a7
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/cmd/internal/testdir/testdir_test.go
View file

@ -63,6 +63,7 @@ var (
cgoEnabled bool
goExperiment string
goDebug string
tmpDir string
// dirs are the directories to look for *.go files in.
// TODO(bradfitz): just use all directories?
@ -115,6 +116,7 @@ func Test(t *testing.T) {
cgoEnabled, _ = strconv.ParseBool(env.CGO_ENABLED)
goExperiment = env.GOEXPERIMENT
goDebug = env.GODEBUG
tmpDir = t.TempDir()
common := testCommon{
gorootTestDir: filepath.Join(testenv.GOROOT(t), "test"),
@ -220,12 +222,8 @@ var stdlibImportcfg = sync.OnceValue(func() string {
})
var stdlibImportcfgFile = sync.OnceValue(func() string {
tmpdir, err := os.MkdirTemp("", "importcfg")
if err != nil {
log.Fatal(err)
}
filename := filepath.Join(tmpdir, "importcfg")
err = os.WriteFile(filename, []byte(stdlibImportcfg()), 0644)
filename := filepath.Join(tmpDir, "importcfg")
err := os.WriteFile(filename, []byte(stdlibImportcfg()), 0644)
if err != nil {
log.Fatal(err)
}