Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

more "declared and not used".

Browse source 
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=

R=r
OCL=34624
CL=34638
This commit is contained in:
Russ Cox 2009-09-15 09:41:59 -07:00
parent 1a3198907b
commit ca6a0fee1b
95 changed files with 221 additions and 218 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/pkg/regexp/all_test.go
View file

@ -348,7 +348,7 @@ var replaceTests = []ReplaceTest {
}
func TestReplaceAll(t *testing.T) {
for i, tc := range replaceTests {
for _, tc := range replaceTests {
re, err := Compile(tc.pattern);
if err != nil {
t.Errorf("Unexpected error compiling %q: %v", tc.pattern, err);
@ -379,7 +379,7 @@ var quoteMetaTests = []QuoteMetaTest {
}
func TestQuoteMeta(t *testing.T) {
for i, tc := range quoteMetaTests {
for _, tc := range quoteMetaTests {
// Verify that QuoteMeta returns the expected string.
quoted := QuoteMeta(tc.pattern);
if quoted != tc.output {
@ -449,7 +449,7 @@ func printStringSlice(t *testing.T, s []string) {
func TestAllMatches(t *testing.T) {
ch := make(chan matchCase);
go func() {
for i, c := range matchCases {
for _, c := range matchCases {
ch <- c;
stringCase := matchCase{
"string" + c.matchfunc,
@ -464,7 +464,7 @@ func TestAllMatches(t *testing.T) {
for c := range ch {
var result []string;
re, err := Compile(c.regexp);
re, _ := Compile(c.regexp);
switch c.matchfunc {
case "matchit":
@ -488,7 +488,7 @@ func TestAllMatches(t *testing.T) {
result = make([]string, len(c.input) + 1);
b := strings.Bytes(c.input);
i := 0;
for j, match := range re.AllMatches(b, c.n) {
for _, match := range re.AllMatches(b, c.n) {
result[i] = string(match);
i++;
}