Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-06-28 03:40:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/go/internal/telemetrystats: add go/platform/target/port:*-* counter

Browse source 
CL 587115 added separate counters for target GOOS and target GOARCH:

	go/platform/target/{goos,goarch}:*

For the purpose of being able to tell usage of each target port
(telemetry proposal go.dev/issue/79214), we need both GOOS and GOARCH
to be counted together, so that for example it's possible to tell how
many counts of goarch:arm64 came from each of windows/arm64 and
darwin/arm64 Go ports. This CL adds the counter:

	go/platform/target/port:*-*

Maybe this makes the separate goos: and goarch: counters redundant,
and they can eventually be removed.

For #79214.

Change-Id: I7ba9259c59e2b635a2b082ab7aa41e67da9bdc8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/775981
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This commit is contained in:
Dmitri Shuralyov 2026-05-08 12:58:39 -04:00 • committed by Gopher Robot
parent a5a336cda2
commit cd913caa3f
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/cmd/go/internal/telemetrystats/telemetrystats.go
View file

@ -41,6 +41,7 @@ func incrementConfig() {
counter.Inc("go/platform/target/goos:" + cfg.Goos)
counter.Inc("go/platform/target/goarch:" + cfg.Goarch)
counter.Inc("go/platform/target/port:" + cfg.Goos + "-" + cfg.Goarch)
switch cfg.Goarch {
case "386":
counter.Inc("go/platform/target/go386:" + cfg.GO386)