Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-10-19 11:03:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: skip windows stack tests in race mode

Browse source 
These became race instrumented in CL 643897, but race mode uses more
memory, so the test doesn't make much sense.

For #71395.

Change-Id: I6a6a636cf09ba29625aa9a22550314845fb2e611
Reviewed-on: https://go-review.googlesource.com/c/go/+/675077
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Pratt 2025-05-21 13:36:42 -04:00 • committed by Gopher Robot
parent d2f229db7a
commit ce49eb488a
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/runtime/crash_cgo_test.go
View file

@ -597,6 +597,9 @@ func TestWindowsStackMemoryCgo(t *testing.T) {
if runtime.GOOS != "windows" {
t.Skip("skipping windows specific test")
}
if race.Enabled {
t.Skip("skipping test: race mode uses more stack memory")
}
testenv.SkipFlaky(t, 22575)
o := runTestProg(t, "testprogcgo", "StackMemory")
stackUsage, err := strconv.Atoi(o)

4
src/runtime/syscall_windows_test.go
View file

@ -7,6 +7,7 @@ package runtime_test
import (
"fmt"
"internal/abi"
"internal/race"
"internal/syscall/windows/sysdll"
"internal/testenv"
"io"
@ -668,6 +669,9 @@ func TestWERDialogue(t *testing.T) {
}
func TestWindowsStackMemory(t *testing.T) {
if race.Enabled {
t.Skip("skipping test: race mode uses more stack memory")
}
o := runTestProg(t, "testprog", "StackMemory")
stackUsage, err := strconv.Atoi(o)
if err != nil {