Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-11-04 10:40:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: fix parsing literal IP address in builtin dns stub resolver

Browse source 
This CL fixes a bug introduced by CL 128820043 which is that
builtin dns stub resolver doesn't work well with literal IPv6
address namesever entries in /etc/resolv.conf.

Also simplifies resolv.conf parser and adds more test cases.

LGTM=iant
R=golang-codereviews, bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/140040043
This commit is contained in:
Mikio Hara 2014-09-04 10:00:30 +09:00
parent 55fa7659c9
commit ced0ba5628
7 changed files with 83 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pkg/net/dnsclient_unix_test.go
View file

@ -204,7 +204,7 @@ func TestReloadResolvConfChange(t *testing.T) {
if _, err := goLookupIP("golang.org"); err != nil {
t.Fatalf("goLookupIP(good) failed: %v", err)
}
r.WantServers([]string{"[8.8.8.8]"})
r.WantServers([]string{"8.8.8.8"})
// Using a bad resolv.conf when we had a good one
// before should not update the config
@ -215,7 +215,7 @@ func TestReloadResolvConfChange(t *testing.T) {
// A new good config should get picked up
r.SetConf("nameserver 8.8.4.4")
r.WantServers([]string{"[8.8.4.4]"})
r.WantServers([]string{"8.8.4.4"})
}
func BenchmarkGoLookupIP(b *testing.B) {