Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: tweak ssa.html colors

Browse source 
Make yellow the last highlight color rather than the first.
Yellow is also the color that Chrome uses to highlight
search results, which can be confusing.
Also, when Night Shift is on on macOS,
yellow highlighting is completely invisible.
I suppose should be sleeping instead.

Also, remove a completed TODO.

Change-Id: I0eb4439272fad9ccb5fe8e2cf409fdd5dc15b26e
Reviewed-on: https://go-review.googlesource.com/43463
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Josh Bleecher Snyder 2017-05-13 08:29:47 -07:00
parent 61336b78c1
commit cfae61b65a
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/compile/internal/ssa/html.go
View file

@ -142,13 +142,13 @@ dd.ssa-prog {
<script type="text/javascript"> <script type="text/javascript">
// ordered list of all available highlight colors // ordered list of all available highlight colors
var highlights = [ var highlights = [
"highlight-yellow",
"highlight-aquamarine", "highlight-aquamarine",
"highlight-coral", "highlight-coral",
"highlight-lightpink", "highlight-lightpink",
"highlight-lightsteelblue", "highlight-lightsteelblue",
"highlight-palegreen", "highlight-palegreen",
"highlight-lightgray" "highlight-lightgray",
"highlight-yellow"
]; ];
// state: which value is highlighted this color? // state: which value is highlighted this color?
@ -264,8 +264,6 @@ function toggle_visibility(id) {
</script> </script>
</head>`) </head>`)
// TODO: Add javascript click handlers for blocks
// to outline that block across all phases
w.WriteString("<body>") w.WriteString("<body>")
w.WriteString("<h1>") w.WriteString("<h1>")
w.WriteString(html.EscapeString(name)) w.WriteString(html.EscapeString(name))