Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-10-19 11:03:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

slices: update TestIssue68488 to avoid false positives

Browse source 
Fixes #74387

Even tho we are abusing unsafe.SliceData a bit here it's probably fine;
in case this test fail, it means some memory alias is happening
which is not good for GC purposes.

We don't care about false keep alives for stack locations tho.

Change-Id: I9434bad8c6d9fbc39c738690617dc7cf91d82aef
Reviewed-on: https://go-review.googlesource.com/c/go/+/684755
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
This commit is contained in:
Jorropo 2025-06-28 02:20:22 +02:00 • committed by Gopher Robot
parent 27ad1f5013
commit d168ad18e1
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/slices/slices_test.go
View file

@ -1454,6 +1454,8 @@ func TestRepeatPanics(t *testing.T) {
}
}
var leak *int
func TestIssue68488(t *testing.T) {
s := make([]int, 3)
clone := Clone(s[1:1])
@ -1461,6 +1463,7 @@ func TestIssue68488(t *testing.T) {
case &s[0], &s[1], &s[2]:
t.Error("clone keeps alive s due to array overlap")
}
leak = &s[1] // see go.dev/issue/74387
}
// This test asserts the behavior when the primary slice operand is nil.