Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: fix conversion error message for printed slices

Browse source 
Fixes #15055.

Updates exprfmt printing using fmt verb "%v" to check that n.Left
is non-nil before attempting to print it, otherwise we'll print
the nodes in the list using verb "%.v".

Credit to @mdempsky for this approach and for finding
the root cause of the issue.

Change-Id: I20a6464e916dc70d5565e145164bb9553e5d3865
Reviewed-on: https://go-review.googlesource.com/25361
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Emmanuel Odeke 2016-07-30 01:45:27 -07:00 • committed by Matthew Dempsky
parent b443babad4
commit dba0d38298
2 changed files with 23 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/cmd/compile/internal/gc/fmt.go
View file

@ -1335,14 +1335,15 @@ func (n *Node) exprfmt(s fmt.State, prec int) {
OSTRARRAYRUNE,
ORUNESTR:
if n.Type == nil || n.Type.Sym == nil {
fmt.Fprintf(s, "(%v)(%v)", n.Type, n.Left)
return
fmt.Fprintf(s, "(%v)", n.Type)
} else {
fmt.Fprintf(s, "%v", n.Type)
}
if n.Left != nil {
fmt.Fprintf(s, "%v(%v)", n.Type, n.Left)
return
fmt.Fprintf(s, "(%v)", n.Left)
} else {
fmt.Fprintf(s, "(%.v)", n.List)
}
fmt.Fprintf(s, "%v(%.v)", n.Type, n.List)
case OREAL,
OIMAG,