Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: fix unified IR shapifying recursive instantiated types

Browse source 
Shape-based stenciling in unified IR is done by converting type argument
to its underlying type. So it agressively check that type argument is
not a TFORW. However, for recursive instantiated type argument, it may
still be a TFORW when shapifying happens. Thus the assertion failed,
causing the compiler crashing.

To fix it, just allow fully instantiated type when shapifying.

Fixes #54512
Fixes #54722

Change-Id: I527e3fd696388c8a37454e738f0324f0c2ec16cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/426335
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Cuong Manh Le 2022-08-29 17:25:32 +07:00 • committed by Gopher Robot
parent c22865fcfa
commit ddc93a536f
5 changed files with 67 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/cmd/compile/internal/noder/reader.go
View file

@ -817,7 +817,22 @@ func (dict *readerDict) mangle(sym *types.Sym) *types.Sym {
// If basic is true, then the type argument is used to instantiate a
// type parameter whose constraint is a basic interface.
func shapify(targ *types.Type, basic bool) *types.Type {
base.Assertf(targ.Kind() != types.TFORW, "%v is missing its underlying type", targ)
if targ.Kind() == types.TFORW {
if targ.IsFullyInstantiated() {
// For recursive instantiated type argument, it may still be a TFORW
// when shapifying happens. If we don't have targ's underlying type,
// shapify won't work. The worst case is we end up not reusing code
// optimally in some tricky cases.
if base.Debug.Shapify != 0 {
base.Warn("skipping shaping of recursive type %v", targ)
}
if targ.HasShape() {
return targ
}
} else {
base.Fatalf("%v is missing its underlying type", targ)
}
}
// When a pointer type is used to instantiate a type parameter
// constrained by a basic interface, we know the pointer's element