mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
cmd/link: expand a TODO comment
CL 231397 is submitted too fast... Expand the comment to make it a little clearer. Change-Id: Ica9737aa7b51f97320bab74457388dcab8188370 Reviewed-on: https://go-review.googlesource.com/c/go/+/231597 Reviewed-by: Austin Clements <austin@google.com>
This commit is contained in:
parent
30f8074e35
commit
e0e0dab411
1 changed files with 4 additions and 2 deletions
|
|
@ -159,8 +159,10 @@ func (d *deadcodePass) flood() {
|
|||
if a.Type() == goobj2.AuxGotype && !d.ctxt.linkShared {
|
||||
// A symbol being reachable doesn't imply we need its
|
||||
// type descriptor. Don't mark it.
|
||||
// XXX we need that for GCProg generation when linking
|
||||
// shared library. why?
|
||||
// TODO: when -linkshared, the GCProg generation code
|
||||
// seems to need it. I'm not sure why. I think it could
|
||||
// just reach to the type descriptor's data without
|
||||
// requiring to mark it reachable.
|
||||
continue
|
||||
}
|
||||
d.mark(a.Sym(), symIdx)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue