Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.typeparams] cmd/dist: disable -G=3 on the std go tests for now

Browse source 
Disable -G=3 tests on the std go tests, in order to see if -G=3 is
causing the flakiness for the dev.typeparams builder, as opposed to
other changes in typeparams branch. It's possible that -G=3 is using
more CPU/RAM that causes flakiness, as opposed to more specific bugs.

Change-Id: I610bce2aabd26b2b1fddc5e63f85ffe4e958e0d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/292850
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dan Scales <danscales@google.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Dan Scales <danscales@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Dan Scales 2021-02-16 18:24:48 -08:00
parent a06bd9fecb
commit e196cb8258
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/dist/test.go vendored
View file

@ -444,8 +444,12 @@ func (t *tester) registerTests() {
fatalf("Error running go list std cmd: %v:\n%s", err, cmd.Stderr) fatalf("Error running go list std cmd: %v:\n%s", err, cmd.Stderr)
} }
pkgs := strings.Fields(string(all)) pkgs := strings.Fields(string(all))
if false {
// Disable -G=3 option for standard tests for now, since
// they are flaky on the builder.
for _, pkg := range pkgs { for _, pkg := range pkgs {
t.registerStdTest(pkg, true) t.registerStdTest(pkg, true /* -G=3 flag */)
}
} }
for _, pkg := range pkgs { for _, pkg := range pkgs {
t.registerStdTest(pkg, false) t.registerStdTest(pkg, false)