mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
runtime: always keep global reference to mp until mexit completes
Ms are allocated via standard heap allocation (`new(m)`), which means we must keep them alive (i.e., reachable by the GC) until we are completely done using them. Ms are primarily reachable through runtime.allm. However, runtime.mexit drops the M from allm fairly early, long before it is done using the M structure. If that was the last reference to the M, it is now at risk of being freed by the GC and used for some other allocation, leading to memory corruption. Ms with a Go-allocated stack coincidentally already keep a reference to the M in sched.freem, so that the stack can be freed lazily. This reference has the side effect of keeping this Ms reachable. However, Ms with an OS stack skip this and are at risk of corruption. Fix this lifetime by extending sched.freem use to all Ms, with the value of mp.freeWait determining whether the stack needs to be freed or not. Fixes #56243. Change-Id: Ic0c01684775f5646970df507111c9abaac0ba52e Reviewed-on: https://go-review.googlesource.com/c/go/+/443716 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
parent
a8e4b8c2a7
commit
e252dcf9d3
32 changed files with 78 additions and 54 deletions
|
|
@ -7,6 +7,7 @@ package runtime
|
|||
import (
|
||||
"internal/abi"
|
||||
"internal/goarch"
|
||||
"runtime/internal/atomic"
|
||||
"unsafe"
|
||||
)
|
||||
|
||||
|
|
@ -182,7 +183,7 @@ func newosproc(mp *m) {
|
|||
}
|
||||
}
|
||||
|
||||
func exitThread(wait *uint32) {
|
||||
func exitThread(wait *atomic.Uint32) {
|
||||
// We should never reach exitThread on Solaris because we let
|
||||
// libc clean up threads.
|
||||
throw("exitThread")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue