Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

testing/quick: improve function signature error.

Browse source 
This commit fixes a cosmetic defect whereby quick.Check reports that
the provided function returns too many values when it may, in fact,
return too few:

  func f() {}

  func TestFoo(t *testing.T) {
    if err := quick.Check(f, nil); err != nil {
      t.Fatal(err)
    }
  }
  // yields
  // $ go test -v foo_test.go
  // === RUN TestFoo
  // --- FAIL: TestFoo (0.00s)
  // 	foo_test.go:76: function returns more than one value.

Change-Id: Ia209ff5b57375b30f8db425454e80798908e8ff4
Reviewed-on: https://go-review.googlesource.com/11281
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Matt T. Proud 2015-06-20 06:29:18 +02:00 • committed by Russ Cox
parent fe15da62f7
commit e6ad56c711
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/testing/quick/quick.go
View file

@ -249,7 +249,7 @@ func Check(f interface{}, config *Config) (err error) {
}
if fType.NumOut() != 1 {
err = SetupError("function returns more than one value.")
err = SetupError("function does not return one value")
return
}
if fType.Out(0).Kind() != reflect.Bool {