Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

go/types, types2: shorten object map assertion

Browse source 
It's a fairly well-known invariant that each object must exist in the
object map and cannot be nil. This change just shortens a check of
that invariant.

Change-Id: Id15c158c3a9ad91cdc230fb0b84eb69b2451cbdc
Reviewed-on: https://go-review.googlesource.com/c/go/+/722061
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Mark Freeman <markfreeman@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
This commit is contained in:
Mark Freeman 2025-11-14 15:04:28 -05:00 • committed by Gopher Robot
parent 02d1f3a06b
commit e704b0993b
2 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/cmd/compile/internal/types2/decl.go
View file

@ -133,11 +133,8 @@ func (check *Checker) objDecl(obj Object, def *TypeName) {
check.push(obj)
defer check.pop()
d := check.objMap[obj]
if d == nil {
check.dump("%v: %s should have been declared", obj.Pos(), obj)
panic("unreachable")
}
d, ok := check.objMap[obj]
assert(ok)
// save/restore current environment and set up object environment
defer func(env environment) {

7
src/go/types/decl.go
View file

@ -134,11 +134,8 @@ func (check *Checker) objDecl(obj Object, def *TypeName) {
check.push(obj) // mark as grey
defer check.pop()
d := check.objMap[obj]
if d == nil {
check.dump("%v: %s should have been declared", obj.Pos(), obj)
panic("unreachable")
}
d, ok := check.objMap[obj]
assert(ok)
// save/restore current environment and set up object environment
defer func(env environment) {