Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-02-07 02:09:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

os: use minimal file permissions when opening parent directory in RemoveAll

Browse source 
On Windows, the process might not have read permission on the parent
directory, but still can delete files in it. This change allows
RemoveAll to open the parent directory with minimal permissions, which
is sufficient for deleting child files.

Fixes #74134.

Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest,gotip-windows-arm64
Change-Id: I5d5c5977caaebf6e0f93fb2313b0ceb346f70e05
Reviewed-on: https://go-review.googlesource.com/c/go/+/684515
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
This commit is contained in:
qmuntal 2025-06-27 11:16:54 +02:00 • committed by Quim Muntal
parent 2a22aefa1f
commit e81c624656
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/os/removeall_at.go
View file

@ -8,6 +8,7 @@ package os
import (
"io"
"runtime"
"syscall"
)
@ -34,7 +35,15 @@ func removeAll(path string) error {
// its parent directory
parentDir, base := splitPath(path)
parent, err := Open(parentDir)
flag := O_RDONLY
if runtime.GOOS == "windows" {
// On Windows, the process might not have read permission on the parent directory,
// but still can delete files in it. See https://go.dev/issue/74134.
// We can open a file even if we don't have read permission by passing the
// O_WRONLY | O_RDWR flag, which is mapped to FILE_READ_ATTRIBUTES.
flag = O_WRONLY | O_RDWR
}
parent, err := OpenFile(parentDir, flag, 0)
if IsNotExist(err) {
// If parent does not exist, base cannot exist. Fail silently
return nil