Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

strings: avoid unnecessary variable setting

Browse source 
We initialize fieldStart to 0, then set it to i without ever reading
0, so we might as well just initialize it to i.

Change-Id: I17905b25d54a62b6bc76f915353756ed5eb6972b
Reviewed-on: https://go-review.googlesource.com/52933
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Avelino <t@avelino.xxx>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Kevin Burke 2017-08-02 22:24:22 -07:00 • committed by Brad Fitzpatrick
parent 254f8ea9ea
commit e93eb2843c
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/strings/strings.go
View file

@ -363,7 +363,6 @@ func Fields(s string) []string {
// a non-ASCII rune needs to be decoded and checked // a non-ASCII rune needs to be decoded and checked
// if it corresponds to a space. // if it corresponds to a space.
a := make([]string, 0, n) a := make([]string, 0, n)
fieldStart := 0
i := 0 i := 0
// Skip spaces in the front of the input. // Skip spaces in the front of the input.
for i < len(s) { for i < len(s) {
@ -380,7 +379,7 @@ func Fields(s string) []string {
i += w i += w
} }
} }
fieldStart = i fieldStart := i
for i < len(s) { for i < len(s) {
if c := s[i]; c < utf8.RuneSelf { if c := s[i]; c < utf8.RuneSelf {
if asciiSpace[c] == 0 { if asciiSpace[c] == 0 {