mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
[dev.typeparams] cmd/compile: fix small -G=3 issues for tests disabled in run.go
- set correct position for closure capture variable in (*irgen).use() (issue20250.go) Also, evaluate rhs, lhs in that order in assignment statements to match noder1 (affects ordering of closure variables). - make sure to set Assign flag properly in (*irgen).forStmt() for range variables which are map accesses (issue9691.go) - make sure CheckSize() is call on the base type for top-level types converted by (*irgen).typ() that are pointer types (issue20174.go and issue37837.go) - deal with parentheses properly in validation function (*irgen).validate() (issue17270.go) - avoid HasNil call on type TTYPEPARAM - types2 typechecker will have already checked validity of the typeparam having nil value (new test issue39755.go) Change-Id: Ie68004d964698aea047e19e7dcd79b297e9d47ca Reviewed-on: https://go-review.googlesource.com/c/go/+/334733 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
parent
3d8453e00e
commit
ed9e109dc9
7 changed files with 58 additions and 11 deletions
|
|
@ -55,7 +55,15 @@ func (g *irgen) validate(n syntax.Node) {
|
|||
case *syntax.CallExpr:
|
||||
tv := g.info.Types[n.Fun]
|
||||
if tv.IsBuiltin() {
|
||||
switch builtin := n.Fun.(type) {
|
||||
fun := n.Fun
|
||||
for {
|
||||
builtin, ok := fun.(*syntax.ParenExpr)
|
||||
if !ok {
|
||||
break
|
||||
}
|
||||
fun = builtin.X
|
||||
}
|
||||
switch builtin := fun.(type) {
|
||||
case *syntax.Name:
|
||||
g.validateBuiltin(builtin.Value, n)
|
||||
case *syntax.SelectorExpr:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue