Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: fix list test memory management for mayMoreStack

Browse source 
The NIH tests simply failed to allocate the nodes outside the heap at
all. The Manual tests failed to keep the nodes alive, allowing the GC to
collect them.

Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Change-Id: I6a6a636c434bb703d6888383d32dbf95fb0a15ea
Reviewed-on: https://go-review.googlesource.com/c/go/+/719962
TryBot-Bypass: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
Michael Pratt 2025-11-12 15:20:54 -05:00
parent 48127f656b
commit f03d06ec1a
1 changed files with 25 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

41
src/runtime/list_manual_test.go
View file

@ -21,10 +21,19 @@ type listedValManual struct {
bNode runtime.ListNodeManual
}
// ListHeadManual is intended to be used with objects where the lifetime of the
// object is managed explicitly, so it is OK to store as uintptr.
//
// This means that our test values must outlive the test, and must not live on
// the stack (which may move).
var allListedValManual []*listedValManual
func newListedValManual(v int) *listedValManual {
return &listedValManual{
lv := &listedValManual{
val: v,
}
allListedValManual = append(allListedValManual, lv)
return lv
}
func TestListManualPush(t *testing.T) {
@ -239,13 +248,13 @@ func TestListNIHPush(t *testing.T) {
headA := newListHeadNIH()
headA.Init(unsafe.Offsetof(listedValNIH{}.aNode))
one := newListedVal(1)
one := newListedValNIH(1)
headA.Push(unsafe.Pointer(one))
two := newListedVal(2)
two := newListedValNIH(2)
headA.Push(unsafe.Pointer(two))
three := newListedVal(3)
three := newListedValNIH(3)
headA.Push(unsafe.Pointer(three))
p := headA.Pop()
@ -296,13 +305,13 @@ func TestListNIHRemoveHead(t *testing.T) {
headA := newListHeadNIH()
headA.Init(unsafe.Offsetof(listedValNIH{}.aNode))
one := newListedVal(1)
one := newListedValNIH(1)
headA.Push(unsafe.Pointer(one))
two := newListedVal(2)
two := newListedValNIH(2)
headA.Push(unsafe.Pointer(two))
three := newListedVal(3)
three := newListedValNIH(3)
headA.Push(unsafe.Pointer(three))
headA.Remove(unsafe.Pointer(three))
@ -326,13 +335,13 @@ func TestListNIHRemoveMiddle(t *testing.T) {
headA := newListHeadNIH()
headA.Init(unsafe.Offsetof(listedValNIH{}.aNode))
one := newListedVal(1)
one := newListedValNIH(1)
headA.Push(unsafe.Pointer(one))
two := newListedVal(2)
two := newListedValNIH(2)
headA.Push(unsafe.Pointer(two))
three := newListedVal(3)
three := newListedValNIH(3)
headA.Push(unsafe.Pointer(three))
headA.Remove(unsafe.Pointer(two))
@ -356,13 +365,13 @@ func TestListNIHRemoveTail(t *testing.T) {
headA := newListHeadNIH()
headA.Init(unsafe.Offsetof(listedValNIH{}.aNode))
one := newListedVal(1)
one := newListedValNIH(1)
headA.Push(unsafe.Pointer(one))
two := newListedVal(2)
two := newListedValNIH(2)
headA.Push(unsafe.Pointer(two))
three := newListedVal(3)
three := newListedValNIH(3)
headA.Push(unsafe.Pointer(three))
headA.Remove(unsafe.Pointer(one))
@ -386,13 +395,13 @@ func TestListNIHRemoveAll(t *testing.T) {
headA := newListHeadNIH()
headA.Init(unsafe.Offsetof(listedValNIH{}.aNode))
one := newListedVal(1)
one := newListedValNIH(1)
headA.Push(unsafe.Pointer(one))
two := newListedVal(2)
two := newListedValNIH(2)
headA.Push(unsafe.Pointer(two))
three := newListedVal(3)
three := newListedValNIH(3)
headA.Push(unsafe.Pointer(three))
headA.Remove(unsafe.Pointer(one))