Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.typeparams] cmd/compile: added a builtins.go test, fixed one bug

Browse source 
The builtins.go test is derived from
cmd/compile/internal/types2/testdata/check/builtins.go2, after removing
the error cases.  Added a few extra tests for len/cap/append.

Fixed one bug, which is that DELETE operations can't be transformed if
their argument is a typeparam. Also, the tranform of LEN/CAP calls does
not need to be delayed. Removed out-date references to the old
typechecker in the comments.

Change-Id: If7a21506a7ff63ff7c8e87ccd614ef4ff3a0d3c8
Reviewed-on: https://go-review.googlesource.com/c/go/+/336010
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
This commit is contained in:
Dan Scales 2021-07-20 09:37:35 -07:00
parent e6a2cf233f
commit f19e49e7b1
3 changed files with 124 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/cmd/compile/internal/noder/helpers.go
View file

@ -126,22 +126,17 @@ func Call(pos src.XPos, typ *types.Type, fun ir.Node, args []ir.Node, dots bool)
}
if fun, ok := fun.(*ir.Name); ok && fun.BuiltinOp != 0 {
// For Builtin ops, we currently stay with using the old
// typechecker to transform the call to a more specific expression
// and possibly use more specific ops. However, for a bunch of the
// ops, we delay doing the old typechecker if any of the args have
// type params, for a variety of reasons:
// For most Builtin ops, we delay doing transformBuiltin if any of the
// args have type params, for a variety of reasons:
//
// OMAKE: hard to choose specific ops OMAKESLICE, etc. until arg type is known
// OREAL/OIMAG: can't determine type float32/float64 until arg type know
// OLEN/OCAP: old typechecker will complain if arg is not obviously a slice/array.
// OAPPEND: old typechecker will complain if arg is not obviously slice, etc.
//
// We will eventually break out the transforming functionality
// needed for builtin's, and call it here or during stenciling, as
// appropriate.
// OMAKE: transformMake can't choose specific ops OMAKESLICE, etc.
// until arg type is known
// OREAL/OIMAG: transformRealImag can't determine type float32/float64
// until arg type known
// OAPPEND: transformAppend requires that the arg is a slice
// ODELETE: transformDelete requires that the arg is a map
switch fun.BuiltinOp {
case ir.OMAKE, ir.OREAL, ir.OIMAG, ir.OLEN, ir.OCAP, ir.OAPPEND:
case ir.OMAKE, ir.OREAL, ir.OIMAG, ir.OAPPEND, ir.ODELETE:
hasTParam := false
for _, arg := range args {
if arg.Type().HasTParam() {