Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

all: prefer strings.IndexByte over strings.Index

Browse source 
strings.IndexByte was introduced in go1.2 and it can be used
effectively wherever the second argument to strings.Index is
exactly one byte long.

This avoids generating unnecessary string symbols and saves
a few calls to strings.Index.

Change-Id: I1ab5edb7c4ee9058084cfa57cbcc267c2597e793
Reviewed-on: https://go-review.googlesource.com/65930
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Marvin Stenger 2017-09-21 19:01:27 +02:00 • committed by Ian Lance Taylor
parent 5e92c41128
commit f22ba1f247
55 changed files with 81 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/cmd/compile/internal/gc/main.go
View file

@ -364,7 +364,7 @@ func Main(archInit func(*Arch)) {
// _ in phase name also matches space
phase := name[4:]
flag := "debug" // default flag is debug
if i := strings.Index(phase, "/"); i >= 0 {
if i := strings.IndexByte(phase, '/'); i >= 0 {
flag = phase[i+1:]
phase = phase[:i]
}
@ -689,7 +689,7 @@ func addImportMap(s string) {
if strings.Count(s, "=") != 1 {
log.Fatal("-importmap argument must be of the form source=actual")
}
i := strings.Index(s, "=")
i := strings.IndexByte(s, '=')
source, actual := s[:i], s[i+1:]
if source == "" || actual == "" {
log.Fatal("-importmap argument must be of the form source=actual; source and actual must be non-empty")
@ -712,13 +712,13 @@ func readImportCfg(file string) {
}
var verb, args string
if i := strings.Index(line, " "); i < 0 {
if i := strings.IndexByte(line, ' '); i < 0 {
verb = line
} else {
verb, args = line[:i], strings.TrimSpace(line[i+1:])
}
var before, after string
if i := strings.Index(args, "="); i >= 0 {
if i := strings.IndexByte(args, '='); i >= 0 {
before, after = args[:i], args[i+1:]
}
switch verb {