Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: omit ICE diagnostics after normal error messages

Browse source 
After we detect errors, the AST is in a precarious state and more
likely to trip useless ICE failures. Instead let the user fix any
existing errors and see if the ICE persists.  This makes Fatalf more
consistent with how panics are handled by hidePanic.

While here, also fix detection for release versions: release version
strings begin with "go" ("go1.8", "go1.9.1", etc), not "release".

Fixes #22252.

Change-Id: I1c400af62fb49dd979b96e1bf0fb295a81c8b336
Reviewed-on: https://go-review.googlesource.com/70850
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Matthew Dempsky 2017-10-13 14:47:45 -07:00
parent e01eac371a
commit f3d4ff7ddc
1 changed files with 15 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/cmd/compile/internal/gc/subr.go
View file

@ -166,20 +166,22 @@ func Warnl(line src.XPos, fmt_ string, args ...interface{}) {
func Fatalf(fmt_ string, args ...interface{}) { func Fatalf(fmt_ string, args ...interface{}) {
flusherrors() flusherrors()
fmt.Printf("%v: internal compiler error: ", linestr(lineno)) if Debug_panic != 0 || nsavederrors+nerrors == 0 {
fmt.Printf(fmt_, args...) fmt.Printf("%v: internal compiler error: ", linestr(lineno))
fmt.Printf("\n") fmt.Printf(fmt_, args...)
// If this is a released compiler version, ask for a bug report.
if strings.HasPrefix(objabi.Version, "release") {
fmt.Printf("\n") fmt.Printf("\n")
fmt.Printf("Please file a bug report including a short program that triggers the error.\n")
fmt.Printf("https://golang.org/issue/new\n") // If this is a released compiler version, ask for a bug report.
} else { if strings.HasPrefix(objabi.Version, "go") {
// Not a release; dump a stack trace, too. fmt.Printf("\n")
fmt.Println() fmt.Printf("Please file a bug report including a short program that triggers the error.\n")
os.Stdout.Write(debug.Stack()) fmt.Printf("https://golang.org/issue/new\n")
fmt.Println() } else {
// Not a release; dump a stack trace, too.
fmt.Println()
os.Stdout.Write(debug.Stack())
fmt.Println()
}
} }
hcrash() hcrash()