Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-06-27 19:30:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile/internal/noder: update UIR to V4

Browse source 
This change flips the use of GOEXPERIMENT=genericmethods around.
We now default to V4 and revert to V3 if the flag is enabled.
This helps rule out generic methods entirely if we encounter
issues during the freeze which might be related.

Again, this flag will not be included in the Go 1.27 release.

For #77273

Change-Id: Ic68faff197867ba672107f07fa2b92ce64b9d3ef
Reviewed-on: https://go-review.googlesource.com/c/go/+/779221
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Mark Freeman 2026-05-18 12:19:34 -04:00
parent 813b317cc9
commit f3f3d0859a
6 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/importer/genmeth_test.go
View file

@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//go:build goexperiment.genericmethods
package importer
import (

6
src/cmd/compile/internal/noder/unified.go
View file

@ -26,12 +26,12 @@ import (
)
// uirVersion is the unified IR version to use for encoding/decoding.
// Use V4 for generic methods if the GOEXPERIMENT is enabled.
// Use V4 for generic methods. Revert to V3 if the GOEXPERIMENT is enabled.
var uirVersion = func() pkgbits.Version {
if buildcfg.Experiment.GenericMethods {
return pkgbits.V4
return pkgbits.V3
}
return pkgbits.V3
return pkgbits.V4
}()
// localPkgReader holds the package reader used for reading the local

2
src/go/internal/gcimporter/genmeth_test.go
View file

@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//go:build goexperiment.genericmethods
package gcimporter_test
import (

2
test/genmeth.go
View file

@ -1,4 +1,4 @@
// run -goexperiment genericmethods
// run
// Copyright 2026 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style

2
test/genmeth1.go
View file

@ -1,4 +1,4 @@
// run -goexperiment genericmethods
// run
// Copyright 2026 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style

2
test/genmeth2.go
View file

@ -1,4 +1,4 @@
// run -goexperiment genericmethods
// run
// Copyright 2026 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style