Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

bytes: limit allocation in SplitN

Browse source
This commit is contained in:
Philippe Antoine 2022-04-04 22:09:07 +02:00
parent 6f1dce0fcb
commit f8df09d65e
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/bytes/bytes.go
View file

@ -348,6 +348,9 @@ func genSplit(s, sep []byte, sepSave, n int) [][]byte {
if n < 0 { if n < 0 {
n = Count(s, sep) + 1 n = Count(s, sep) + 1
} }
if n > len(s)+1 {
n = len(s) + 1
}
a := make([][]byte, n) a := make([][]byte, n)
n-- n--

2
src/bytes/bytes_test.go
View file

@ -8,6 +8,7 @@ import (
. "bytes" . "bytes"
"fmt" "fmt"
"internal/testenv" "internal/testenv"
"math"
"math/rand" "math/rand"
"reflect" "reflect"
"strings" "strings"
@ -723,6 +724,7 @@ var splittests = []SplitTest{
{"1 2", " ", 3, []string{"1", "2"}}, {"1 2", " ", 3, []string{"1", "2"}},
{"123", "", 2, []string{"1", "23"}}, {"123", "", 2, []string{"1", "23"}},
{"123", "", 17, []string{"1", "2", "3"}}, {"123", "", 17, []string{"1", "2", "3"}},
{"bT", "T", math.MaxInt / 4, []string{"b", ""}},
} }
func TestSplit(t *testing.T) { func TestSplit(t *testing.T) {