mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
runtime: make NumGoroutine and Stack agree not to include system goroutines
[Repeat of CL 18343 with build fixes.]
Before, NumGoroutine counted system goroutines and Stack (usually) didn't show them,
which was inconsistent and confusing.
To resolve which way they should be consistent, it seems like
package main
import "runtime"
func main() { println(runtime.NumGoroutine()) }
should print 1 regardless of internal runtime details. Make it so.
Fixes #11706.
Change-Id: If26749fec06aa0ff84311f7941b88d140552e81d
Reviewed-on: https://go-review.googlesource.com/18432
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
This commit is contained in:
parent
1e066cad1b
commit
fac8202c3f
6 changed files with 53 additions and 6 deletions
|
|
@ -9,6 +9,7 @@ import (
|
|||
"net"
|
||||
"runtime"
|
||||
"runtime/debug"
|
||||
"strings"
|
||||
"sync"
|
||||
"sync/atomic"
|
||||
"syscall"
|
||||
|
|
@ -336,6 +337,23 @@ func TestGCFairness(t *testing.T) {
|
|||
}
|
||||
}
|
||||
|
||||
func TestNumGoroutine(t *testing.T) {
|
||||
output := runTestProg(t, "testprog", "NumGoroutine")
|
||||
want := "1\n"
|
||||
if output != want {
|
||||
t.Fatalf("want %q, got %q", want, output)
|
||||
}
|
||||
|
||||
buf := make([]byte, 1<<20)
|
||||
buf = buf[:runtime.Stack(buf, true)]
|
||||
|
||||
n := runtime.NumGoroutine()
|
||||
|
||||
if nstk := strings.Count(string(buf), "goroutine "); n != nstk {
|
||||
t.Fatalf("NumGoroutine=%d, but found %d goroutines in stack dump", n, nstk)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPingPongHog(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("skipping in -short mode")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue