mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
19a30ea3f2
This change creates calls to size-specialized malloc functions instead of calls to newObject when we know the size of the allocation at compilation time. Most of it is a matter of calling the newObject function (which will create calls to the size-specialized functions) rather then the newObjectNonSpecialized function (which won't). In the newHeapaddr, small, non-pointer case, we'll create a non specialized newObject and transform that into the appropriate size-specialized function when we produce the mallocgc in flushPendingHeapAllocations. We have to update some of the rewrites in generic.rules to also apply to the size-specialized functions when they apply to newObject. The messiest thing is we have to adjust the offset we use to save the memory profiler stack, because the depth of the call to profilealloc is two frames fewer in the size-specialized malloc functions compared to when newObject calls mallocgc. A bunch of tests have been adjusted to account for that. Change-Id: I6a6a6964c9037fb6719e392c4a498ed700b617d7 Reviewed-on: https://go-review.googlesource.com/c/go/+/707856 Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org>
65 lines
2.2 KiB
Go
65 lines
2.2 KiB
Go
// errorcheck -0 -l -m -live
|
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis and liveness inferred for uintptrescapes functions.
|
|
|
|
package p
|
|
|
|
import (
|
|
"unsafe"
|
|
)
|
|
|
|
//go:uintptrescapes
|
|
func F1(a uintptr) {} // ERROR "escaping uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func F2(a ...uintptr) {} // ERROR "escaping ...uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func F3(uintptr) {} // ERROR "escaping uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func F4(...uintptr) {} // ERROR "escaping ...uintptr"
|
|
|
|
type T struct{}
|
|
|
|
//go:uintptrescapes
|
|
func (T) M1(a uintptr) {} // ERROR "escaping uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func (T) M2(a ...uintptr) {} // ERROR "escaping ...uintptr"
|
|
|
|
func TestF1() {
|
|
var t int // ERROR "moved to heap"
|
|
F1(uintptr(unsafe.Pointer(&t))) // ERROR "live at call to F1: .?autotmp" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestF3() {
|
|
var t2 int // ERROR "moved to heap"
|
|
F3(uintptr(unsafe.Pointer(&t2))) // ERROR "live at call to F3: .?autotmp" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestM1() {
|
|
var t T
|
|
var v int // ERROR "moved to heap"
|
|
t.M1(uintptr(unsafe.Pointer(&v))) // ERROR "live at call to T.M1: .?autotmp" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestF2() {
|
|
var v int // ERROR "moved to heap"
|
|
F2(0, 1, uintptr(unsafe.Pointer(&v)), 2) // ERROR "live at call to mallocgcSmallNoScanSC[0-9]+: .?autotmp" "live at call to F2: .?autotmp" "escapes to heap" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestF4() {
|
|
var v2 int // ERROR "moved to heap"
|
|
F4(0, 1, uintptr(unsafe.Pointer(&v2)), 2) // ERROR "live at call to mallocgcSmallNoScanSC[0-9]+: .?autotmp" "live at call to F4: .?autotmp" "escapes to heap" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestM2() {
|
|
var t T
|
|
var v int // ERROR "moved to heap"
|
|
t.M2(0, 1, uintptr(unsafe.Pointer(&v)), 2) // ERROR "live at call to mallocgcSmallNoScanSC[0-9]+: .?autotmp" "live at call to T.M2: .?autotmp" "escapes to heap" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|