Alberto Donizetti 42cc4ca30a cmd/compile: prevent overflow in walkinrange ... In the compiler frontend, walkinrange indiscriminately calls Int64() on const CTINT nodes, even though Int64's return value is undefined for anything over 2⁶³ (in practise, it'll return a negative number). This causes the introduction of bad constants during rewrites of unsigned expressions, which make the compiler reject valid Go programs. This change introduces a preliminary check that Int64() is safe to call on the consts on hand. If it isn't, walkinrange exits without doing any rewrite. Fixes #27143 Change-Id: I2017073cae65468a521ff3262d4ea8ab0d7098d9 Reviewed-on: https://go-review.googlesource.com/130735 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>		2018-08-26 21:52:27 +00:00
..
builtin	runtime/race: implement race detector for ppc64le	2018-06-11 17:45:36 +00:00
testdata	cmd/compile: remove vet-blocking hack	2018-08-24 22:59:36 +00:00
alg.go	cmd/compile: make generated function code more consistent	2018-04-20 01:09:31 +00:00
align.go	cmd/compile/internal/types: replace Type.Val with Type.Elem	2018-04-24 22:37:52 +00:00
bexport.go	cmd/compile: fix ICE due to missing inline function body	2018-07-12 00:13:37 +00:00
bimport.go	cmd/compile: fix exporting of 'for' loops	2018-06-19 16:35:58 +00:00
bitset.go	cmd/compile: inline calls to local closures	2017-10-11 22:32:36 +00:00
bootstrap.go	cmd/compile: add mutex profiling support	2017-04-05 22:10:54 +00:00
builtin.go	runtime/race: implement race detector for ppc64le	2018-06-11 17:45:36 +00:00
builtin_test.go	all: use testing.GoToolPath instead of "go"	2016-08-30 22:49:11 +00:00
bv.go	cmd/compile/internal/gc: various minor cleanups	2018-08-20 13:27:53 +00:00
class_string.go	cmd: re-generate all stringer files	2018-03-10 21:20:50 +00:00
closure.go	cmd/compile: add convnop helper function	2018-08-23 06:10:48 +00:00
const.go	cmd/compile: prevent overflow in walkinrange	2018-08-26 21:52:27 +00:00
constFold_test.go	cmd/compile: use std "DO NOT EDIT" comment for generated files	2017-03-31 18:50:40 +00:00
dcl.go	cmd/compile: revert internal parameter rename (from ".anonX" to "") before export	2018-06-05 20:22:07 +00:00
dwinl.go	cmd/compile/internal/gc: various minor cleanups	2018-08-20 13:27:53 +00:00
esc.go	cmd/compile/internal/gc: remove commented-out code from esc.go	2018-08-22 16:55:08 +00:00
export.go	cmd/compile/internal/gc: various minor cleanups	2018-08-20 13:27:53 +00:00
fixedbugs_test.go	cmd/compile: move Issue 16214 test, delete asm_test file	2018-04-16 11:51:56 +00:00
float_test.go	cmd/compile: test constant folded integer to/from float conversions	2017-09-16 09:17:58 +00:00
fmt.go	cmd/compile: display AST IR in ssa.html	2018-08-24 19:11:12 +00:00
gen.go	cmd/compile: merge tempnamel into tempAt	2017-08-28 22:46:30 +00:00
global_test.go	all: use testing.GoToolPath instead of "go"	2016-08-30 22:49:11 +00:00
go.go	cmd/compile/internal/gc: unexport Deferproc and Newproc	2018-08-21 08:12:06 +00:00
gsubr.go	cmd/compile, cmd/internal/obj: record register maps in binary	2018-05-22 15:55:03 +00:00
iexport.go	cmd/compile: export the Func.Endlineno field	2018-08-23 05:11:26 +00:00
iface_test.go	cmd/compile: inline convT2{I,E} when result doesn't escape	2016-09-19 02:37:08 +00:00
iimport.go	cmd/compile: export the Func.Endlineno field	2018-08-23 05:11:26 +00:00
init.go	cmd/compile: cleaner solution for importing init functions	2018-04-26 23:21:28 +00:00
inl.go	cmd/compile: add sources for inlined functions to ssa.html	2018-08-23 05:11:33 +00:00
inl_test.go	runtime: allow inlining of stackmapdata	2018-05-01 19:14:17 +00:00
lex.go	cmd/compile: fix double go prefix trim	2018-04-15 19:22:11 +00:00
lex_test.go	cmd/compile, cmd/link: encode cgo directives using JSON	2018-04-11 23:35:42 +00:00
logic_test.go	cmd/compile: add tests for logical simplification rewrite rules	2016-05-26 22:16:52 +00:00
main.go	cmd/compile: clean the output of GOSSAFUNC	2018-08-23 05:11:17 +00:00
mapfile_mmap.go	cmd/compile: add indexed export format	2018-04-24 01:05:27 +00:00
mapfile_read.go	cmd/compile: add indexed export format	2018-04-24 01:05:27 +00:00
mkbuiltin.go	cmd/compile: factor out Pkg, Sym, and Type into package types	2017-04-07 03:04:00 +00:00
mpfloat.go	cmd/compile: change cmplx{mpy,div} into Mpcplx methods	2018-04-06 19:25:08 +00:00
mpint.go	cmd/compile/internal/gc: various minor cleanups	2018-08-20 13:27:53 +00:00
noder.go	cmd/compile: add doc comment to the parseFiles function	2018-06-11 17:27:48 +00:00
norace.go	cmd/compile: randomize compilation order when race-enabled	2017-04-27 19:27:22 +00:00
obj.go	cmd/compile, cmd/internal/obj: record register maps in binary	2018-05-22 15:55:03 +00:00
op_string.go	cmd: re-generate all stringer files	2018-03-10 21:20:50 +00:00
order.go	cmd/compile: optimize map-clearing range idiom	2018-05-08 21:15:16 +00:00
pgen.go	cmd/compile: include callee args section when checking frame too large	2018-06-02 18:00:44 +00:00
pgen_test.go	cmd/compile: move Used from gc.Node to gc.Name	2017-04-27 22:58:13 +00:00
phi.go	all: update comment URLs from HTTP to HTTPS, where possible	2018-06-01 21:52:00 +00:00
plive.go	cmd/compile: handle degenerate write barrier case	2018-07-12 19:06:09 +00:00
pprof.go	cmd/compile: add mutex profiling support	2017-04-05 22:10:54 +00:00
race.go	cmd/compile: randomize compilation order when race-enabled	2017-04-27 19:27:22 +00:00
racewalk.go	cmd/compile: omit racefuncentry/exit when they are not needed	2018-08-20 22:07:22 +00:00
range.go	cmd/compile: add convnop helper function	2018-08-23 06:10:48 +00:00
reflect.go	cmd/compile: make duplicate anonymous interface output deterministic	2018-08-17 15:34:50 +00:00
reproduciblebuilds_test.go	cmd/compile: make builds reproducible in presence of **byte and **int8	2017-05-09 21:15:12 +00:00
scope.go	cmd/compile/internal/gc: various cleanups	2018-03-24 19:44:18 +00:00
scope_test.go	cmd/compile/internal/gc: various minor cleanups	2018-08-20 13:27:53 +00:00
select.go	cmd/compile: add convnop helper function	2018-08-23 06:10:48 +00:00
shift_test.go	cmd/compile: test non-constant shifts	2016-06-01 00:06:00 +00:00
sinit.go	cmd/compile/internal/types: replace Type.Val with Type.Elem	2018-04-24 22:37:52 +00:00
sizeof_test.go	cmd/compile: extract inline related fields into separate Inline type	2018-04-05 05:12:36 +00:00
ssa.go	cmd/compile: display AST IR in ssa.html	2018-08-24 19:11:12 +00:00
ssa_test.go	cmd/compile: move last compile tests to new test infrastructure	2018-08-24 22:59:12 +00:00
subr.go	cmd/compile: add convnop helper function	2018-08-23 06:10:48 +00:00
swt.go	cmd/compile: ensure that operand of ORETURN is not double-walked	2018-06-14 20:08:10 +00:00
swt_test.go	cmd/compile: reduce reliance on implementation details of Mpint	2017-04-07 17:08:34 +00:00
syntax.go	cmd/compile: don't produce a past-the-end pointer in range loops	2018-05-22 14:15:46 +00:00
timings.go	cmd/compile: add compiler phase timing	2016-08-17 17:27:04 +00:00
trace.go	cmd/compile/internal/gc: add runtime/trace support	2016-10-12 13:57:26 +00:00
truncconst_test.go	cmd/compile: diagnose constant division by complex zero	2017-04-12 17:29:28 +00:00
typecheck.go	cmd/compile: use embedlineno instead of lineno in copytype	2018-08-22 21:16:54 +00:00
types.go	cmd/compile/internal/types: remove Cmptmp	2017-04-07 22:11:36 +00:00
types_acc.go	cmd/compile: factor out Pkg, Sym, and Type into package types	2017-04-07 03:04:00 +00:00
universe.go	cmd/compile: fix Node.Etype overloading	2018-03-09 21:44:35 +00:00
unsafe.go	cmd/compile: silence unnecessary unsafe error	2017-10-24 02:28:02 +00:00
util.go	cmd/compile: add mutex profiling support	2017-04-05 22:10:54 +00:00
walk.go	cmd/compile: prevent overflow in walkinrange	2018-08-26 21:52:27 +00:00