4c4cefc19a
Rather than stat-ing each argument and taking different code paths depending on whether it's a directory or not, we can leverage the fact that filepath.WalkDir works on regular files and already has to figure out whether each file it walks is a directory or not. We can then implement "always format non-directory arguments" by looking at whether the path we are walking is the original argument, meaning we are walking the top file. For full clarity, we expand the skipping logic with a switch, as before it was a bit confusing how we could `return err` on directories and other non-Go files. Given that we discard directories separately now, simplify isGoFile to just be about filenames. While here, also note that we called AddReport inside WalkDir; this is unnecessary, as we can return the error for the same effect. Change-Id: I50ab94710143f19bd8dd95a69e01a3dd228e397e Reviewed-on: https://go-review.googlesource.com/c/go/+/700115 Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.